Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated local repo dir processing #19

Merged
merged 1 commit into from
May 8, 2024

Conversation

jsumners-nr
Copy link
Contributor

This PR resolves some expectations around --repo-dir:

  1. The directory specified by --repo-dir will not be removed during clean up (burned me 😢)
  2. Adds a --no-externals flag to skip processing of the predefined external repos (default is to process them)
  3. Docs around --test-dir updated to make it clear it only applies to the repo provided by --repo-dir

The result is that nrversions -r path/to/repo will process everything in path/to/repo along with the external repos, thus generating the full report. Utilizing nrversions -r path/to/repo -n will only process path/to/repo if that is needed for some reason.

@jsumners-nr jsumners-nr marked this pull request as ready for review May 8, 2024 14:56
@jsumners-nr jsumners-nr merged commit 17c3da6 into newrelic:main May 8, 2024
4 checks passed
@jsumners-nr jsumners-nr deleted the local-and-externals branch May 8, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants